-
Notifications
You must be signed in to change notification settings - Fork 121
Fix: Customer Details Screen Not Scrollable After Selecting Country #16289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workaround works, but it makes the experience of editing the form a bit irritating IMO. When I want to tap on a field that is under the keyboard, I'd need to scroll > the keyboard is dismissed > then the keyboard is presented again when I tap on the field I want.
How about addressing the issue a bit differently by dismissing the keyboard before showing the state or country pickers? Something like this:
.onChange(of: showStateSelector) {
UIApplication.shared.sendAction(#selector(UIResponder.resignFirstResponder), to: nil, from: nil, for: nil)
}
.onChange(of: showCountrySelector) {
UIApplication.shared.sendAction(#selector(UIResponder.resignFirstResponder), to: nil, from: nil, for: nil)
}
@itsmeichigo Yeah , this is much better than my initial approach. Thanks for the hint. |
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!

Closes WOOMOB-1382
Description
This PR fixes the linked issue by setting the outer view to dismiss the keyboard when content is scrolled.
Test Steps
Screenshots
RELEASE-NOTES.txtif necessary.